chore(wren-ai-service): sql2answer-minor-update #691
Merged
+133
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyeh
added
module/ai-service
paopa
reviewed
Oct 2, 2024
Comment on lines
62
to
81
| # check if the model is actually Vertex AI model | ||
| self._vertexai_creds = None | ||
| if model.startswith("google/"): | ||
| self._vertexai_creds, _ = google.auth.default( | ||
| scopes=["https://www.googleapis.com/auth/cloud-platform"] | ||
| ) | ||
|
|
||
| def __getattr__(self, name: str) -> Any: | ||
| # dealing with auto-refreshing expired credential | ||
| # https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/call-vertex-using-openai-library#refresh_your_credentials | ||
| if self._vertexai_creds and not self._vertexai_creds.valid: | ||
| auth_req = google.auth.transport.requests.Request() | ||
| self._vertexai_creds.refresh(auth_req) | ||
|
|
||
| if not self._vertexai_creds.valid: | ||
| raise RuntimeError("Unable to refresh auth") | ||
|
|
||
| self.client.api_key = self._vertexai_creds.token | ||
| return getattr(self.client, name) | ||
|
|
There was a problem hiding this comment.
a bit curious, why did we validate the credit of vertexai in the openai provider?
paopa
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow auto-refresh expired vertexai credentials